Restore atheris stubs #15140
Restore atheris stubs #15140
Conversation
This reverts commit 106078c.
This comment has been minimized.
This comment has been minimized.
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
Is there any chance that this will confuse the stub-uploader to start again uploading stubs that were previously removed?
| # TODO (2025-03-05): unskip once `atheris` can be installed on `ubuntu-24.04`, | ||
| # see https://github.com/python/typeshed/pull/13582 and | ||
| # https://github.com/google/atheris/issues/82 | ||
| skip = true |
There was a problem hiding this comment.
can we try unskipping this and see what CI says?
| # TODO (2025-03-05): unskip once `atheris` can be installed on `ubuntu-24.04`, | |
| # see https://github.com/python/typeshed/pull/13582 and | |
| # https://github.com/google/atheris/issues/82 | |
| skip = true |
There was a problem hiding this comment.
Considering that stubtest in CI uses 3.13 and this version of atheris only supports 3.12, I'd wait for us to update the stubs to 3.0.0 before doing that.
|
Should it also be updated to the latest version, 3.0.0? |
we should do that in a separate PR, it might (probably will?) cause CI failures because our stubs will likely need to be updated |
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
I'm happy if we think the stub uploader will be happy!
There is a chance, yes. But honestly, I don't think anything serious can break that can't be fixed rather easily. Also, all old metadata is still present, so I hope it will just work. |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
sounds good 🤞 |
|
For reference, I just forced an update, and everything seems fine: https://pypi.org/project/types-atheris/ https://github.com/typeshed-internal/stub_uploader/actions/runs/20339008656/job/58432887006 |
3 participants
This reverts commit 106078c.
Cf #14185 (comment)