This repository was archived by the owner on Aug 1, 2023. It is now read-only.
Make target-text-file optional in generate.py#559
Open
cndn wants to merge 1 commit intopytorch:masterfrom
Open
Make target-text-file optional in generate.py#559cndn wants to merge 1 commit intopytorch:masterfrom
cndn wants to merge 1 commit intopytorch:masterfrom
Conversation
Summary: Now --target-text-file is mandatory when --source-text-file is specified. However for getting translation without evaluation it's not necessary. Remove the validation. LMK if there are potential concerns. Differential Revision: D15540664 fbshipit-source-id: 71889cdbad746abbcbc07968994f9c9f733b204e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Now --target-text-file is mandatory when --source-text-file is specified. However for getting translation without evaluation it's not necessary. Remove the validation.
LMK if there are potential concerns.
Differential Revision: D15540664