Open
Conversation
This fixes "reading" NO-BREAK SPACE chars (0xC2 0xA0) on arm. Example char: https://github.com/storm-devs/sd-teho-public/blob/f916551822b6b4f1c4c3c77c312379e3d3aec23e/program/seadogs.c#L1073 Where read fails on arm: https://github.com/storm-devs/storm-engine/blob/c729a650c7a45b46b72010935803c2ca5bed297a/src/libs/core/src/token.cpp#L917
Also remove unused class DColor
This fixes gcc build.
In order not to overlap the _rdtsc function from sse2neon.h
This reverts commit 1c81834.
q4a
force-pushed
the
arm-gcc-win-same-lin
branch
2 times, most recently
from
997e806 to
306c47c
Compare
1) 1 in libs/core/src/compiler.cpp 2) 1 in libs/diagnostics/src/lifecycle_diagnostics_service.cpp 3) 2 in libs/diagnostics/src/spdlog_sinks/syncable_sink.cpp 4) 1 in libs/lighter/src/l_geometry.cpp 5) 1 in libs/renderer/include/dx9render.h 6) 1 in libs/renderer/src/s_device.cpp 7) 1 in libs/renderer/src/storm_d3dx9.cpp 8) 1 in libs/util/src/platform.cpp 9) 1 in libs/util/include/platform/platform.hpp 10) 1 in libs/util/include/utf8.h 11) 1 in libs/window/src/sdl_window.cpp 12) 2 in libs/xinterface/src/xinterface.cpp I replaced "def _WIN32" with "defined(_WIN32)" in that exeptions.
replace: def false // _WIN32 // S_DEBUG with: def _WIN32 // S_DEBUG replace: def false // _WIN32 // HINSTANCE with: def _WIN32 // HINSTANCE
q4a
force-pushed
the
arm-gcc-win-same-lin
branch
from
306c47c to
955bd14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.