Implement the password support #671
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
mohitk108
force-pushed
the
feature/pw-support
branch
from
b394157 to
3325dd7
Compare
Author
|
I have read the CLA Document and I hereby sign the CLA |
mohitk108
force-pushed
the
feature/pw-support
branch
from
f4c2f05 to
0248f4e
Compare
mohitk108
force-pushed
the
feature/pw-support
branch
from
0248f4e to
2dd37be
Compare
MathJud
requested changes
Jul 28, 2025
Member
There was a problem hiding this comment.
This file must not be changed here, as it marks the upgrade procedure to qaul version 2.0.0-rc.1
We must create a new folder and a new qaul version (2.0.0 rc.4) to make the configuration file upgrade needed for your changes.
This should be done shortly before merging the PR(s) and must to reflect all changes of the configuration file.
mohitk108
force-pushed
the
feature/pw-support
branch
from
a348fdb to
883b375
Compare
mohitk108
force-pushed
the
feature/pw-support
branch
from
883b375 to
474d821
Compare
…anagement functions
mohitk108
force-pushed
the
feature/pw-support
branch
from
474d821 to
63ffd51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #531
Note:
Completed the core logic of adding password support, which includes updating the protobuf definitions. Also, I've been using unwraps in some places, and would add proper error handling at the completion of this PR.
I'm using
qaul_id: PeerIdinstead of QaulId, that would be updatedUpdate:
The commit history is now sane.
The protobuf definitions have been revised based on our IRC chat.