Skip to content

Fixed critical issue with package involving duplicate gates#211

Merged
brennanfreeze merged 1 commit intomainfrom
brennanfreeze/issue180-debug
Jun 5, 2025
Merged

Fixed critical issue with package involving duplicate gates#211
brennanfreeze merged 1 commit intomainfrom
brennanfreeze/issue180-debug

Conversation

@brennanfreeze
Copy link
Member

Pull Request

Description

There was a critical error that was happening in the tests where the duplicate chain was checking the dummy entry and was trying to access NULL values, added a check to determine if the null id (which is set in the qlog_node) is 0. This is 100% going to get changed ASAP but is a good fix to continue other segments of the optimization code and will not affect anything else (hopefully).

Type of Change

Please check the type of change your PR introduces:

  • Bugfix
  • New feature
  • Enhancement
  • Documentation
  • Refactoring
  • Other (please specify):

Checklist

  • I have read the contributing guidelines.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the documentation accordingly.
  • I ran black formatter on the codebase. (CI/CD will fail if neglected)
  • My code follows the project's coding style guidelines.

Related Issues

Screenshots (if applicable)

If your change includes visual updates, please include screenshots to demonstrate the changes.

Additional Notes

Add any additional notes or comments here. For example, describe any known issues or limitations.

@brennanfreeze brennanfreeze merged commit c2dd9bc into main Jun 5, 2025
0 of 2 checks passed
@brennanfreeze brennanfreeze deleted the brennanfreeze/issue180-debug branch June 5, 2025 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant