Fixed critical issue with package involving duplicate gates#211
Merged
brennanfreeze merged 1 commit intomainfrom Jun 5, 2025
Merged
Fixed critical issue with package involving duplicate gates#211brennanfreeze merged 1 commit intomainfrom
brennanfreeze merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
There was a critical error that was happening in the tests where the duplicate chain was checking the dummy entry and was trying to access NULL values, added a check to determine if the null id (which is set in the qlog_node) is 0. This is 100% going to get changed ASAP but is a good fix to continue other segments of the optimization code and will not affect anything else (hopefully).
Type of Change
Please check the type of change your PR introduces:
Checklist
blackformatter on the codebase. (CI/CD will fail if neglected)Related Issues
Screenshots (if applicable)
If your change includes visual updates, please include screenshots to demonstrate the changes.
Additional Notes
Add any additional notes or comments here. For example, describe any known issues or limitations.