Skip to content

fix export to json bug #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
etokareva wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix export to json bug #557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/export/export.service.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
declare function flattenObject(obj: object, separator: string): object;
declare function flatView(obj: object, separator?: string): object;

export {
flattenObject
flatView
};
28 changes: 8 additions & 20 deletions core/export/json/json.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,30 +1,18 @@
import {flatView} from '../export.service';

function updateTitles(rows, titles) {
const result = [];
for (let row of rows) {
const obj = {};
const values = Object.values(row);
for (let i = 0; i < titles.length; i++) {
obj[titles[i]] = values[i];
}
result.push(obj);
}
return JSON.stringify(result, '', 4);
}

export class Json {
write(rows, columns) {
const titles = [];
const result = [];

for (let row of rows) {
result.push(flatView(row));
}
for (let column of columns) {
titles.push(column.title);
const flatRow = flatView(row);
const obj = {};
for (let column of columns) {
obj[column.title] = flatRow[column.key];
}
result.push(obj);
}

return updateTitles(result, titles);
return JSON.stringify(result, '', 4);
}
}
}