feat: add fullstack-fp workflow and Dockerfile with PHP 8.5 support #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds a new fullstack-fp Docker variant with FrankenPHP support and extends PHP version support to 8.5 across the build workflows.
Key Changes:
- Introduces new fullstack-fp Docker image variant based on FrankenPHP
- Adds PHP 8.5 to the build matrix for both standard and FrankenPHP workflows
- Removes older PHP versions (7.4, 8.0, 8.1, 8.2) from the standard workflow matrix
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/fullstack-fp/Dockerfile |
New Dockerfile for fullstack-fp variant using FrankenPHP base image with Node.js, Bun, and SonarScanner |
src/fullstack-fp/shell/bashrc |
Bash configuration file with common aliases and safety features |
src/fullstack-fp/shell/aliases.sh |
Laravel/PHP Artisan convenience aliases for development |
.github/workflows/service_docker-build-and-publish.yml |
Updated PHP version matrix to include 8.3, 8.4, and 8.5 only |
.github/workflows/service_docker-build-and-publish-franken.yml |
Added PHP 8.5 to FrankenPHP build matrix |
.github/workflows/publish-docker.yml |
Added fullstack-fp job to stable release workflow |
.github/workflows/publish-docker-beta.yml |
Added fullstack-fp job to beta release workflow |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| COPY shell/aliases.sh /var/www/.aliases.sh | ||
|
|
||
| # Copy shell configuration | ||
| COPY shell/bashrc /root/.sh |
There was a problem hiding this comment.
The file path appears to be incorrect. The target path is /root/.sh but should likely be /root/.bashrc to match the naming convention and the corresponding www-data user configuration on line 67.
Suggested change
| COPY shell/bashrc /root/.sh | |
| COPY shell/bashrc /root/.bashrc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.