Skip to content

Conversation

@EinsPommes
Copy link
Collaborator

Implemented a restart backend button in the EtherCAT device assignment dialog. The button allows users to restart the backend service directly from the dialog after assigning devices.

Copilot AI review requested due to automatic review settings December 20, 2025 13:29
@EinsPommes EinsPommes linked an issue Dec 20, 2025 that may be closed by this pull request
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the EtherCAT device assignment dialog by adding a restart backend button and implementing a touch-friendly numeric keypad for serial number input. The changes improve user workflow by allowing backend restarts directly from the dialog after device assignment.

Key Changes

  • Added a restart backend button with loading states and toast notifications for user feedback
  • Implemented a floating touch numpad component for serial number input with cursor controls and focus management
  • Modified dialog behavior to prevent accidental closure when interacting with the numpad

@EinsPommes EinsPommes assigned EinsPommes and unassigned EinsPommes Dec 20, 2025
Copy link
Member

@TheBest6337 TheBest6337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are there changes for the numpad? This PR should only include the restart button and nothing else.

@EinsPommes
Copy link
Collaborator Author

Oh yes, I will fix it.

@MilanVDB MilanVDB requested a review from Oshgnacknak December 24, 2025 09:39
@TheBest6337
Copy link
Member

What are you doing? You should only add a Restart button, not change anything else. The progress bar doesn't need an time estimate! And specifically not in this Issue.

@EinsPommes EinsPommes force-pushed the 917-add-an-restart-backend-process-button-to-ethercat-assigment branch 2 times, most recently from b03a235 to 769fdb5 Compare December 26, 2025 08:22
@EinsPommes
Copy link
Collaborator Author

Sorry, I didn't switch branches and accidentally added the time estimate to the wrong branch (917-add-an-restart-backend-process-button-to-ethercat-assigment). This issue should only include the restart button. The branch is now cleaned up and only contains the restart button changes. The time estimate belongs in a separate issue/branch. Sorry for the confusion.

Implemented a restart backend button in the EtherCAT device assignment dialog. The button allows users to restart the backend service directly from the dialog after assigning devices.
- Added restart backend service button to EtherCAT device assignment dialog
- Button includes loading state and proper error handling
- Updated alert message to clarify backend service restart requirement
- Fixed typo in function name (DeviceEepromDialogContent)
- Removed empty comment block
@kraemr kraemr force-pushed the 917-add-an-restart-backend-process-button-to-ethercat-assigment branch from 7f1244b to 5a08304 Compare January 15, 2026 13:49
@kraemr kraemr self-assigned this Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add an restart backend process button to ethercat assigment

5 participants