-
Notifications
You must be signed in to change notification settings - Fork 20
Add restart backend button to DeviceEepromDialog #998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add restart backend button to DeviceEepromDialog #998
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enhances the EtherCAT device assignment dialog by adding a restart backend button and implementing a touch-friendly numeric keypad for serial number input. The changes improve user workflow by allowing backend restarts directly from the dialog after device assignment.
Key Changes
- Added a restart backend button with loading states and toast notifications for user feedback
- Implemented a floating touch numpad component for serial number input with cursor controls and focus management
- Modified dialog behavior to prevent accidental closure when interacting with the numpad
TheBest6337
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are there changes for the numpad? This PR should only include the restart button and nothing else.
|
Oh yes, I will fix it. |
|
What are you doing? You should only add a Restart button, not change anything else. The progress bar doesn't need an time estimate! And specifically not in this Issue. |
b03a235 to
769fdb5
Compare
|
Sorry, I didn't switch branches and accidentally added the time estimate to the wrong branch (917-add-an-restart-backend-process-button-to-ethercat-assigment). This issue should only include the restart button. The branch is now cleaned up and only contains the restart button changes. The time estimate belongs in a separate issue/branch. Sorry for the confusion. |
Implemented a restart backend button in the EtherCAT device assignment dialog. The button allows users to restart the backend service directly from the dialog after assigning devices.
- Added restart backend service button to EtherCAT device assignment dialog - Button includes loading state and proper error handling - Updated alert message to clarify backend service restart requirement - Fixed typo in function name (DeviceEepromDialogContent) - Removed empty comment block
…g unused references
7f1244b to
5a08304
Compare
Implemented a restart backend button in the EtherCAT device assignment dialog. The button allows users to restart the backend service directly from the dialog after assigning devices.