Skip to content

Modify ffmpeg to avoid drifting in ABR segment generation #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elv-reza wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Modify ffmpeg to avoid drifting in ABR segment generation #22

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a137dfc
Modify ffmpeg to avoid drifting in ABR segment generation
elv-reza Aug 6, 2020
c21b364
Add log for setting start_pts
elv-reza Aug 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions libavformat/dashenc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2068,9 +2068,17 @@ static int dash_write_packet(AVFormatContext *s, AVPacket *pkt)
// If we wrote a previous segment, adjust the start time of the segment
// to the end of the previous one (which is the same as the mp4 muxer
// does). This avoids gaps in the timeline.
#if 0
/*
* Initializing start_pts with max_pts can cause some problem in very odd cases (RM).
* For example with fry's video transcoding max_pts starts to drift 1001 ts after second segment.
* The following change set forces start_pts of the segment to be pkt->pts of the first packet in the segment.
*/
if (os->max_pts != AV_NOPTS_VALUE)
os->start_pts = os->max_pts;
else
#endif
av_log(s, AV_LOG_INFO, "SETTING START_PTS pkt->pts=%"PRId64", max_pts=%"PRId64, pkt->pts, os->max_pts);
os->start_pts = pkt->pts;
}
if (os->max_pts == AV_NOPTS_VALUE)
Expand Down