-
Notifications
You must be signed in to change notification settings - Fork 4
[DRAFT] Move solve to GPU #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
govindchari
wants to merge
9
commits into
main
Choose a base branch
from
gc/fully-gpu-solve
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Download benchmark artifactsBenchmark Summary
Runtime regressions (> 5.0%)
Runtime improvements (> 5.0%)
|
Download benchmark artifactsBenchmark Summary
Runtime regressions (> 5.0%)
Runtime improvements (> 5.0%)
|
Download benchmark artifactsBenchmark Summary
Differences in solved problems
Runtime regressions (> 5.0%)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, only the factorization and solves are performed on the GPU. All other operations are done on the CPU. This incurs significant overhead due to
cudaMemcpy, so this PR seeks to remove allcudaMemcpy.Track down all
get_data_vectorf()calls. These should ideally return GPU pointers, but currently just returns CPU pointers.Then write kernels to operate directly on
QOCOVectorfrather than directly accessing pointers in memory.The main code for QOCO should not touch pointers at all and should just use the QOCOVectorf abstraction.