Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
completeevent when the dictation was just submitted via the hotkey, by distinguishing hotkey vs mouse submit sources.Description
lastDictationSubmitViaHotkeyAtandlastDictationSubmitViaMouseAtinsrc/features/dictationAutoSend.ts.lastDictationSubmitViaHotkeyAtin thehandleKeyDownhotkey submit branch andlastDictationSubmitViaMouseAtin thehandleClicksubmit-click branch.handleTranscribeMessage, skip the transcribe auto-send when a recent hotkey-based dictation submit was the last submit action (checks timestamps and a 1200ms threshold).manifest.jsonfrom1.0.109to1.0.110to reflect the logic change.Testing
npm run lintand it passed.npm run format:checkand it passed.npm run typecheck(tsc --noEmit) and it passed.npm run testandvitest(1 test file) and all tests passed.npm run verify(format/lint/typecheck/build checks) and it completed successfully.Codex Task