Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
ConversionDirectionandconvert_ru_en_with_directionand addedconversion_direction_for_textplus letter-count helpers insrc/domain/text/mapping.rsto allow explicit-direction conversions and deterministic behavior for punctuation-only inputs.expected_direction_for_foreground_window()and layout helpers insrc/domain/text/convert.rsto derive a layout-based fallback from theHKL/LANGID of the foreground window.conversion_direction_for_textand fall back to the foreground layout via aconvert_with_layout_fallbackwrapper, replacing direct uses of the old bidirectional API insrc/domain/text/last_word.rsandsrc/domain/text/convert.rs.&↔?mapping) and added a unit testpunctuation_only_respects_explicit_directioninsrc/tests/mapping_invariants_tests.rs.AGENTS.mdand applied rustfmt-aligned formatting tweaks to a few modules.Testing
cargo +nightly fmt --checkwhich succeeded.cargo +nightly clippy --all-targets --all-features -- -D warningswhich failed due to numerous unresolved Windows API items (thewindowscrate / Win32 symbols are not available in the current CI/host environment), producing type and unresolved-symbol errors.cargo +nightly build --features debug-tracingwhich failed for the same reason (many unresolvedwindowssymbols and environment-specific items), so the project binary could not be built here.cargo +nightly test --lockedwhich also failed because the crate could not be compiled; the new unit test is present but could not be executed due to the build failures described above.Codex Task