fix(resonator): change pulse to set dc #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjwu-qm
requested review from
Kyung-hoon-Jung0,
paulQM and
sebastianorbell-qm
Kyung-hoon-Jung0
approved these changes
Jan 20, 2026
Collaborator
Kyung-hoon-Jung0
left a comment
Kyung-hoon-Jung0
left a comment
There was a problem hiding this comment.
the modification seems correct. :)
Kyung-hoon-Jung0
pushed a commit
that referenced
this pull request
Jan 20, 2026
…ler-flux-set-dc fix(resonator): change pulse to set dc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change updates the coupler-flux sweep in 07_resonator_spectroscopy_vs_coupler_flux.py to use set_dc_offset instead of a constant pulse, so the workflow now tunes the coupler via DC offset during the sweep.