Skip to content

Conversation

@khalidfaisal17
Copy link

This change introduces the TPM2 software stack for iq‑8275‑evk and iq‑9075‑evk targets by enabling the appropriate DISTRO features and installing the TPM2 package group. These updates ensure that the full TPM2 userspace stack and all required dependencies are available only for platforms that support TPM functionality.

TPM is not available on the rb3‑gen2‑core‑kit platform; therefore, the TPM‑related DISTRO_FEATURES and IMAGE_INSTALL additions have been applied specifically to the iq‑8275‑evk and iq‑9075‑evk configuration files.

These changes are necessary to provide the complete TPM stack and enable TPM‑based features to function correctly on supported targets.

Copy link
Contributor

@lumag lumag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these changes belong to meta-qcom-distro. Use COMBINED_FEATURES if necessary.

@lumag
Copy link
Contributor

lumag commented Feb 9, 2026

You have ignored all the review comments. NAK.

@ricardosalveti
Copy link
Contributor

tpm2 should be made available as MACHINE_FEATURES (for the desired targets) and as part of DISTRO_FEATURES for meta-qcom-distro.

Copy link
Contributor

@lumag lumag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change only marks the platform capability and does not enable
any TPM packages by itself.

This is obvious.

TPM userspace components are selected
at the distro level via COMBINED_FEATURES.

This is unrelated and partially not true.

@khalidfaisal17
Copy link
Author

This change only marks the platform capability and does not enable
any TPM packages by itself.

This is obvious.

TPM userspace components are selected
at the distro level via COMBINED_FEATURES.

This is unrelated and partially not true.

updated the commit msg descriptions.

Added meta-security (master branch) and enabled the meta-tpm layer to
support TPM2 stack and utilities in the QCOM Yocto build.

Signed-off-by: Khalid Faisal Ansari <khalid.ansari@oss.qualcomm.com>
Declare TPM2 as a supported machine feature for iq-8275-evk.

This allows TPM-related packages to be conditionally included by
the distro without affecting platforms that do not provide TPM
hardware support.

Signed-off-by: Khalid Faisal Ansari <khalid.ansari@oss.qualcomm.com>
Declare TPM2 as a supported machine feature for iq-9075-evk.

This allows TPM-related packages to be conditionally included by
the distro without affecting platforms that do not provide TPM
hardware support.

Signed-off-by: Khalid Faisal Ansari <khalid.ansari@oss.qualcomm.com>
@khalidfaisal17
Copy link
Author

I am reviewing the build failure logs for Job #63355367900

From the analysis so far, the issue does not appear to be related to the TPM changes introduced in this PR.
Could you please help investigate the cause of the failure so that I can proceed with the next steps?

2026-02-12 07:51:45 - ERROR - Patch 0057-pd-mapper-Introduce-SELinux-domain-for-pd-mapper.patch does not apply (enforce with -f)
2026-02-12 07:51:45 - ERROR -
2026-02-12 07:51:45 - ERROR - stderr: ')

Thank you.

@khalidfaisal17
Copy link
Author

tpm2 should be made available as MACHINE_FEATURES (for the desired targets) and as part of DISTRO_FEATURES for meta-qcom-distro.

Thanks for review, I have raised #PR158 considering tpm2 should get enabled through DISTRO level.

Copy link
Contributor

@lumag lumag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corresponding qcom-distro PR needs to be merged first (and it also needs a small imrovement).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants