-
Notifications
You must be signed in to change notification settings - Fork 195
Enable TPM Stack #1504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Enable TPM Stack #1504
Conversation
lumag
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of these changes belong to meta-qcom-distro. Use COMBINED_FEATURES if necessary.
bf922fe to
a8424ba
Compare
|
You have ignored all the review comments. NAK. |
|
tpm2 should be made available as MACHINE_FEATURES (for the desired targets) and as part of DISTRO_FEATURES for meta-qcom-distro. |
2cdde89 to
1c2be5b
Compare
lumag
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change only marks the platform capability and does not enable
any TPM packages by itself.
This is obvious.
TPM userspace components are selected
at the distro level via COMBINED_FEATURES.
This is unrelated and partially not true.
1c2be5b to
5bee1ca
Compare
updated the commit msg descriptions. |
5bee1ca to
615a471
Compare
Added meta-security (master branch) and enabled the meta-tpm layer to support TPM2 stack and utilities in the QCOM Yocto build. Signed-off-by: Khalid Faisal Ansari <khalid.ansari@oss.qualcomm.com>
Declare TPM2 as a supported machine feature for iq-8275-evk. This allows TPM-related packages to be conditionally included by the distro without affecting platforms that do not provide TPM hardware support. Signed-off-by: Khalid Faisal Ansari <khalid.ansari@oss.qualcomm.com>
Declare TPM2 as a supported machine feature for iq-9075-evk. This allows TPM-related packages to be conditionally included by the distro without affecting platforms that do not provide TPM hardware support. Signed-off-by: Khalid Faisal Ansari <khalid.ansari@oss.qualcomm.com>
615a471 to
977113b
Compare
|
I am reviewing the build failure logs for Job #63355367900 From the analysis so far, the issue does not appear to be related to the TPM changes introduced in this PR.
Thank you. |
Thanks for review, I have raised #PR158 considering tpm2 should get enabled through DISTRO level. |
lumag
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corresponding qcom-distro PR needs to be merged first (and it also needs a small imrovement).
This change introduces the TPM2 software stack for iq‑8275‑evk and iq‑9075‑evk targets by enabling the appropriate DISTRO features and installing the TPM2 package group. These updates ensure that the full TPM2 userspace stack and all required dependencies are available only for platforms that support TPM functionality.
TPM is not available on the rb3‑gen2‑core‑kit platform; therefore, the TPM‑related DISTRO_FEATURES and IMAGE_INSTALL additions have been applied specifically to the iq‑8275‑evk and iq‑9075‑evk configuration files.
These changes are necessary to provide the complete TPM stack and enable TPM‑based features to function correctly on supported targets.