Enable Talos upstream camera DTB compilation for linux-qcom kernel #1535
Conversation
wenmliu
requested review from
lumag,
ndechesne,
ricardosalveti,
sbanerjee-quic and
vkraleti
as code owners
wenmliu
changed the title
| FIT_DTB_COMPATIBLE[sm8450-hdk] = "qcom,sm8450-hdk" | ||
| FIT_DTB_COMPATIBLE[sm8750-mtp] = "qcom,sm8750-mtp" | ||
| FIT_DTB_COMPATIBLE[talos-evk] = "qcom,qcs615v1.1-iot" | ||
| FIT_DTB_COMPATIBLE[talos-evk-camera-imx577] = "qcom,talos-evk" |
There was a problem hiding this comment.
No, this is not a FIT-compatible compat string. Don't do it.
There was a problem hiding this comment.
Yes, but without a temporary solution, the upstream camera will not be included in the build for use testing.
There was a problem hiding this comment.
Add qcom/talos-evk-camera-imx577.dtbo to KERNEL_DEVICETREE.
There was a problem hiding this comment.
If only add qcom/talos-evk-camera-imx577.dtbo to KERNEL_DEVICETREE.
compile will error:
ERROR: linux-qcom-6.18.7-r0 do_generate_qcom_fitimage: FIT_DTB_COMPATIBLE[talos-evk-camera-imx577] is not set.
this is why we post the two changes.
There was a problem hiding this comment.
you need to add
FIT_DTB_COMPATIBLE[talos-evk+talos-evk-camera-imx577] = "qcom,lemans-evk"
There was a problem hiding this comment.
Hi @vkraleti ,
FIT_DTB_COMPATIBLE[talos-evk+talos-evk-camera-imx577] = "qcom,lemans-evk"
talos-evk+talos-evk-camera-imx577 this will cause compile error, talos-evk-camera-imx577 is same with talos-evk, is a dtb too.
qcom,lemans-evk for this, please give the reason why we do not use qcom,talos-evk
There was a problem hiding this comment.
Sorry there is a typo. I mean to add
FIT_DTB_COMPATIBLE[talos-evk+talos-evk-camera-imx577] = "qcom,talos-evk"
There was a problem hiding this comment.
No, "qcom,talos-evk" is NAKed.
|
Please avoid merge commits. |
wenmliu
force-pushed
the
master
branch
2 times, most recently
from
5a7c5ed to
b15861f
Compare
lumag
left a comment
lumag
left a comment
There was a problem hiding this comment.
NAK for the usage of "qcom,talos-evk", it doesn't match the established standard.
Update recipe to pack upstream Camera dtb into final image of IQ-615-EVK (Talos-evk) platform. Signed-off-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
| if not compatible: | ||
| bb.fatal(f"FIT_DTB_COMPATIBLE[{dtb_key}] is not set for base DTB '{fname}'.") | ||
| bb.warn(f"FIT_DTB_COMPATIBLE[{dtb_key}] is not set for base DTB '{fname}'.") | ||
| continue |
There was a problem hiding this comment.
@wenmliu since you dropped the FIT_DTB_COMPATIBLE entry for talos-evk-camera-imx577 This is no longer needed.
Make overlays optional when processing FIT_DTB_COMPATIBLE combinations. Now only the base DTB is required, and overlays are filtered to include only those actually present in KERNEL_DEVICETREE. This supports: - Base DTB only (no overlays) - Partial overlay combinations - Full overlay combinations Signed-off-by: Wenmeng Liu <wenmliu@qti.qualcomm.com>
| if not compatible: | ||
| bb.fatal(f"FIT_DTB_COMPATIBLE[{dtb_key}] is not set for base DTB '{fname}'.") | ||
| bb.warn(f"FIT_DTB_COMPATIBLE[{dtb_key}] is not set for base DTB '{fname}'.") | ||
| continue |
There was a problem hiding this comment.
@wenmliu , I have used this change to generate ITS file for lemans and monaco. Iam not able to see the conf entry for any DTB/DTBOs as shown below:
configurations {
};
4 participants
Update recipe to pack upstream Camera dtb into final dtb image of IQ-615-EVK (Talos-evk) platform.
1.Replace fatal error with warning when DTB lacks compatible string configuration.
2.Add upstream camera DTB compile support.