-
Notifications
You must be signed in to change notification settings - Fork 194
El2 FIT image dtb support for Lemans #1538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
838d10d to
53bf9b1
Compare
0fd5e30 to
13b552e
Compare
d568fe3 to
f767f85
Compare
| @@ -8,7 +8,7 @@ DEPENDS += "dtc-native" | |||
|
|
|||
| SRC_URI = "git://github.com/qualcomm-linux/qcom-dtb-metadata.git;branch=main;protocol=https;tag=v${PV}" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just qcom-dtb-metadata: foo, please. Also, it's not update SRCREV, it's switch to the next release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is now a tag (https://github.com/qualcomm-linux/qcom-dtb-metadata/releases/tag/v0.2), so say you are updating to the corresponding tag version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, tag = release in my opinion, but yeah, tag also works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Test run workflowTest jobs for commit f767f85
All jobs summary
|
Test Results 31 files 31 suites 1h 4m 31s ⏱️ Results for commit f767f85. |
f767f85 to
a6cbbf8
Compare
| FIT_DTB_COMPATIBLE[lemans-evk+lemans-evk-camx+lemans-el2] = " \ | ||
| qcom,qcs9075-iot-camx-el2kvm \ | ||
| qcom,qcs9075v2-iot-camx-el2kvm \ | ||
| " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see new suffix to compatible is added.
Does UEFI release already support the logic to handle -el2kvm, if not this compatible will never get matched ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UEFI does not provide support as of today.
The options I am aware of:
- wait for the uefi team to provide support and then merge, (or)
- merge this pr and then wait on uefi for the new binary with the support, (or)
- any other alternative ?
sbanerjee-quic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The approve was by mistake need to understand the -el2kvm usage
qualcomm-linux/qcom-dtb-metadata#48 adds support for the Lemans EL2 DTB overlay. EL2 DTB overlay support is required during FIT DTB image creation to enable KVM use cases for Lemans. Update SRCREV and version to point to the commit that adds the compatible strings for Lemans EL2 KVM support. Signed-off-by: Keerthivasan Raghavan <kraghava@qti.qualcomm.com>
qualcomm-linux/qcom-dtb-metadata#48 adds support for the Lemans EL2 DTB overlay. There is no existing FIT DTB mapping to allow KVM usecases to be enabled for qcs9100. Add the mapping. Signed-off-by: Keerthivasan Raghavan <kraghava@qti.qualcomm.com>
…3 EL2 qualcomm-linux/qcom-dtb-metadata#48 adds support for the Lemans EL2 DTB overlay. There is no existing FIT DTB mapping to allow KVM usecases to be enabled for qcs9100-ride-r3. Add the mapping. Signed-off-by: Keerthivasan Raghavan <kraghava@qti.qualcomm.com>
qualcomm-linux/qcom-dtb-metadata#48 adds support for the Lemans EL2 DTB overlay. There is no existing FIT DTB mapping to allow KVM usecases to be enabled for qcs9075. Add the mapping. Signed-off-by: Keerthivasan Raghavan <kraghava@qti.qualcomm.com>
a6cbbf8 to
254bda9
Compare
…th CAMX qualcomm-linux/qcom-dtb-metadata#48 adds support for the Lemans EL2 DTB overlay. There is no existing FIT DTB mapping to allow KVM with camex usecases to be enabled for qcs9075. Add the mapping. Signed-off-by: Keerthivasan Raghavan <kraghava@qti.qualcomm.com>
qualcomm-linux/qcom-dtb-metadata#48 introduces support for the Lemans EL2 DTB overlay. KVM use cases are currently disabled due to the absence of the EL2 DTBO. Enable KVM support by adding the EL2 DTBO. Signed-off-by: Keerthivasan Raghavan <kraghava@qti.qualcomm.com>
254bda9 to
ee42908
Compare
qualcomm-linux/qcom-dtb-metadata#48 introduces support for the Lemans EL2 DTB overlay. KVM use cases are currently disabled due to the absence of the EL2 DTBO. Enable KVM support by adding the EL2 DTBO. Signed-off-by: kas User <kas@example.com>
ee42908 to
0aa1e20
Compare
|
Problem with upstream recipe: |
Addressed with #1544 Please rebase once merged. |
qualcomm-linux/qcom-dtb-metadata#48 adds support for the Lemans EL2
DTB overlay.
The EL2 DTB overlay is currently absent for Lemans machines, which
prevents enabling KVM use cases. This change enables EL2 support by
updating the corresponding machine configuration files and FIT DTB
compatible string mappings.