Skip to content

Comments

Update score type to float#473

Merged
drorIvry merged 1 commit intomainfrom
hotfix-|-score-type-to-float
Feb 16, 2026
Merged

Update score type to float#473
drorIvry merged 1 commit intomainfrom
hotfix-|-score-type-to-float

Conversation

@giladivry
Copy link
Contributor

@giladivry giladivry commented Feb 16, 2026

Description

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • [x ] 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

Summary by CodeRabbit

  • Bug Fixes
    • Evaluation scores now support decimal precision for more accurate assessments.

@giladivry giladivry requested a review from drorIvry February 16, 2026 15:25
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 16, 2026

Caution

Review failed

The pull request is closed.

Walkthrough

The score field type in EvaluationResult and EvaluationResponse classes is updated from integer to float, enabling decimal-valued evaluation scores.

Changes

Cohort / File(s) Summary
Type Updates
qualifire/types.py
Score field type changed from int to float in EvaluationResult and EvaluationResponse classes for finer-grained score precision.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

Scores now dance with decimal grace,
No longer bound to whole-count space,
From rigid integers they're freed,
Float precision is all we need! 🐰✨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch hotfix-|-score-type-to-float

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@drorIvry drorIvry enabled auto-merge (squash) February 16, 2026 15:26
@drorIvry drorIvry merged commit 1f00669 into main Feb 16, 2026
8 of 9 checks passed
@drorIvry drorIvry deleted the hotfix-|-score-type-to-float branch February 16, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants