build(git-hooks): Add git-build-hook-maven-plugin + pre-push hook#5
Open
f-lopes wants to merge 1 commit intoquasarch:masterfrom
Open
build(git-hooks): Add git-build-hook-maven-plugin + pre-push hook#5f-lopes wants to merge 1 commit intoquasarch:masterfrom
f-lopes wants to merge 1 commit intoquasarch:masterfrom
Conversation
Contributor
|
Hello @f-lopes. Would you care to explain the reason for this? |
Contributor
Author
|
Hello @GoncaloPT It's a safeguard, preventing users from pushing "non-compliant" changes (build failure, format errors, etc.). I think it's a great way for an open-source library to "guide" the contributors. |
Contributor
|
I see your point. But it would also prevent me to share code with someone else if I want to work together with you for example on the same branch. |
Contributor
Author
|
You can still disable hook using the |
44cd865 to
687a5a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add git-build-hook-maven-plugin + pre-push hook