Skip to content

Conversation

@ThatsNotMySourceCode
Copy link

Updates the Random SC that was IPO'ed end of 2023 with working code.

Compiles in VS, not tested in environment yet. Based on CFB explanations and discussion in https://discord.com/channels/768887649540243497/1447531959931899974.

Some information and usage examples can be found in https://github.com/ThatsNotMySourceCode/Random.

Copy link
Contributor

@philippwerner philippwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reviewed anything in detail, just two quick comments:

@ThatsNotMySourceCode
Copy link
Author

I haven't reviewed anything in detail, just two quick comments:

Hi Philipp,

Where do you want example miner code. It's now in https://github.com/ThatsNotMySourceCode/Random/tree/main/Example.

@N-010
Copy link
Contributor

N-010 commented Dec 11, 2025

@philippwerner here is a PR request to the main branch

@philippwerner philippwerner changed the base branch from main to develop December 12, 2025 06:40
@philippwerner
Copy link
Contributor

philippwerner commented Dec 12, 2025

Guys, read https://github.com/qubic/core/blob/main/doc/contracts.md and fix the problems! If you want to contribute, do it properly and stop wasting the core devs' time!

... no pointers, no [], no local stack variables, etc

Use https://github.com/Franziska-Mueller/qubic-contract-verify

Refactor Random contract structure and logic, improving clarity and organization. Update data structures and variable names for consistency.
@ThatsNotMySourceCode
Copy link
Author

Sorry dr. Phil. It's my first Qubic contract. I wasn't aware of all these rules, I based it on https://docs.qubic.org/developers/smart-contract-architecture/, but then there are other pages elsewhere that have additional rules. In our Discord channel it was suggested to make a PR so others could help and review, I'm just helping to finally get this Random SC live after years...

Anyway, I updated it and it passes the verify tool now. Maybe other devs could review it first.

@philippwerner
Copy link
Contributor

Sorry for my harsh words and thank your for your contribution. I have created an issue for correcting this weakness in the docs: qubic/docs#47
It would be good indeed if someone else could review this, because I'm very busy with implementing oracle support in the core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants