-
Notifications
You must be signed in to change notification settings - Fork 151
Update Random SC #680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Update Random SC #680
Conversation
Release v1.270.0
Release v1.271.0
philippwerner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't reviewed anything in detail, just two quick comments:
- the code breaks several contract language rules, such as no C-style arrays and no pointers are allowed, see https://github.com/qubic/core/blob/main/doc/contracts.md
- the client-side entropy miner code is required as well
Hi Philipp, Where do you want example miner code. It's now in https://github.com/ThatsNotMySourceCode/Random/tree/main/Example. |
|
@philippwerner here is a PR request to the main branch |
|
Guys, read https://github.com/qubic/core/blob/main/doc/contracts.md and fix the problems! If you want to contribute, do it properly and stop wasting the core devs' time! ... no pointers, no [], no local stack variables, etc Use https://github.com/Franziska-Mueller/qubic-contract-verify |
Refactor Random contract structure and logic, improving clarity and organization. Update data structures and variable names for consistency.
|
Sorry dr. Phil. It's my first Qubic contract. I wasn't aware of all these rules, I based it on https://docs.qubic.org/developers/smart-contract-architecture/, but then there are other pages elsewhere that have additional rules. In our Discord channel it was suggested to make a PR so others could help and review, I'm just helping to finally get this Random SC live after years... Anyway, I updated it and it passes the verify tool now. Maybe other devs could review it first. |
|
Sorry for my harsh words and thank your for your contribution. I have created an issue for correcting this weakness in the docs: qubic/docs#47 |
Updates the Random SC that was IPO'ed end of 2023 with working code.
Compiles in VS, not tested in environment yet. Based on CFB explanations and discussion in https://discord.com/channels/768887649540243497/1447531959931899974.
Some information and usage examples can be found in https://github.com/ThatsNotMySourceCode/Random.