Getting images in a jupyter widget without failing tests#39
Merged
jurra merged 3 commits intoqucat:developfrom Dec 13, 2025
Merged
Getting images in a jupyter widget without failing tests#39jurra merged 3 commits intoqucat:developfrom
jurra merged 3 commits intoqucat:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to issue #36.
The problem it solves is:
Jupyter Notebook widget needs images to be in lined (no references).
esbuild does this if you use the syntax:
import myimg from './assets/myimg.png';
mocha testing however will not accept this syntax .
This is a very hacky fix, that replaces GetImage.js with the
URL(imagePath, import.meta.url).href;
syntax before testing and restoring the ‘import’ syntax after testing.
Works for:
The Copilot generated solution to issue #36 is more elegant, very complicated and I’m not convinced it will solve the problem addressed here.
I suggest we go with this hacky solution until we can come up with a better idea, that works for all 3 cases.