Add pattern SString #214
Closed
Add pattern SString #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Actually, the latest incarnation of #208 is pretty lightweight, and this patch is obnoviously CPP-heavy, so dunno if I can claim any improvement ;) Feel free to close, this is just a raw experiment. |
Collaborator
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wonder if this could provide a lightweight resolution to #207, alternative to #208. @newhoggy what do you think?
The idea is to use
SStringto performT.pack/T.unpackwhen on GHC 7.10+ (which covers the vast majority of users) and resort to slowread . show(#207 (comment)) only on older systems.