Stability changes for version 5.0.0#105
Merged
bluestreak01 merged 48 commits intomainfrom Jul 4, 2025
Merged
Conversation
11 tasks
amunra
commented
Jun 17, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR introduces various stability improvements for version 5.0.0, including updated array APIs for both C and C++ clients, consolidated error codes for array handling, and enhancements to protocol version negotiation and documentation.
- Updated test cases and API calls to work with the new array C API and C++ ergonomics for array ingestion.
- Consolidated error codes into a single ArrayError and updated related documentation and examples.
- Adjusted the default maximum name length handling and improved consistency across FFI, Rust, and documentation.
Reviewed Changes
Copilot reviewed 45 out of 48 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| system_test/test.py | Updates DEFAULT_ARRAY_RELEASE version and adds new tests for default max name length and array API examples. |
| system_test/questdb_line_sender.py | Introduces a new simpler C-major array API and modifies pointer casts accordingly. |
| questdb-rs/src/tests/* | Updates tests to use the consolidated ArrayError instead of multiple array-related errors. |
| questdb-rs/src/ingress/* | Updates API implementations and documentation for array ingestion, error code changes, and protocol version support. |
| questdb-rs/examples/* | Updates examples to reflect the new array API usage and clarifies the QuestDB server version requirements. |
| questdb-rs-ffi/* | Adjusts FFI bindings and macros to support the new array API (e.g., using c_double_p). |
| doc/* | Revises documentation and release notes to reference new protocols, API changes, and default settings. |
| CMakeLists.txt & bumpversion files | Update version references and compile instructions for the 5.0.0 release. |
Comments suppressed due to low confidence (1)
questdb-rs/src/ingress/mod.rs:624
- The constant MAX_NAME_LEN_DEFAULT is defined as 127, but the documentation comment mentions a default limit of 32. Please update the comment to match the actual constant value to ensure consistency.
/// For the default max name length limit (32), use [`Self::new`].
nwoolmer
approved these changes
Jul 4, 2025
bluestreak01
approved these changes
Jul 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR is about introducing stability changes targeting the release of version 5.0.0.
Task list
is only suggested for TCP and we advise "auto" for HTTP.
max_line_lenfrom/settings(see point above).line_sender_buffer_column_f64_arr_row_major(we will use this from Python).You mentioned that these are slower than the equivalent Rust
ndarrayAPIs.ArrayErrorcode. These should be consolidated:ArrayHasTooManyDimsArrayViewErrorArrayWriteToBufferErrordata and strides.
length, and assumes default strides (calling
_f64_arr_row_major).(cd questdb-rs && cargo doc --open)E.g.: warning: unresolved link to
Sender::new_buffer_with_max_name_len.version of QuestDB supports arrays.
My guess is that it is going to be 8.4.0, but we need to confirm this.
(I've also added this todo to the Python client TODO list.)
against the
nd_arrbranch. We should also retain a CI test run that runsagainst an older version of QuestDB (e.g. 8.3.3) to ensure that we don't
introduce regressions against protocol version 1.
MAX_ARRAY_BUFFER_SIZE: lower it!Tandem PR
See related
py-questdb-clientPR: questdb/py-questdb-client#108