Conversation
fixup: 5a949ca ("CMake: Set _WIN32_WINNT=0x0601", quickjs-ng#900)
the original is -Ddisable_parser, invert that to make it less confusing
fixup: 8dda2a0 ("fixed hash_map_resize() - added Map/WeakMap in microbench")
fixup: 0a00011 ("Optimize {__proto__:null} object literal creation", quickjs-ng#1118)
fixup: 08db51a ("Add ref-counted string slices", quickjs-ng#1175)
skips building: qjs/qjsc cli, examples, tests, codegen
also removed -M during the test_fib.c codegen: 902cc2c ("Add native module support on Windows") switched examples to dynamic import() instead of static import statement and the lookup was deferred to runtime, thus we don't need to hint qjsc this is a declared module and exclude it from bundling.
Fix unable to `import {fib} from './fib.so';` using qjs cli
|
last 2 commits require #1194 edit: dropped |
libunicode.c
Outdated
| #if __has_include(<codegen_libunicode-table.h>) | ||
| #include <codegen_libunicode-table.h> | ||
| #else | ||
| #include "libunicode-table.h" | ||
| #endif |
There was a problem hiding this comment.
This seems unnecessary? The point of unicode_gen is to produce libunicode-table.h that then gets checked into git.
Us maintainers don't use meson so it's not necessary to have meson build any of it.
There was a problem hiding this comment.
the point of this is explained in #1187, some distributions may like to avoid pregenerated sources
There was a problem hiding this comment.
we could drop this change and keep it downstream, though.
There was a problem hiding this comment.
I'd say let's drop it please.
meson.build
Outdated
| examples = get_option('examples').disable_auto_if(meson.is_subproject()) | ||
|
|
||
| if tests.allowed() | ||
| broken_test = disabler() |
There was a problem hiding this comment.
For my curiosity, what does that do / how does that work?
There was a problem hiding this comment.
if any target depends on a disabler, it will also become a disabler, which is a no-op
mochaaP
force-pushed
the
mochaa-meson-update
branch
from
3c9f47a to
f2aead8
Compare
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
Not a meson expert by any stretch but LGTM insofar I can judge that.
@saghul you want to take a look as well or should I go ahead and merge it?
saghul
left a comment
saghul
left a comment
There was a problem hiding this comment.
LGTM with a question, does this PR depend on the qjsc changes?
| $(QJSC) -e -o gen/hello.c examples/hello.js | ||
| $(QJSC) -e -o gen/hello_module.c -m examples/hello_module.js | ||
| $(QJSC) -e -o gen/test_fib.c -M examples/fib.so,fib -m examples/test_fib.js | ||
| $(QJSC) -e -o gen/test_fib.c -m examples/test_fib.js |
There was a problem hiding this comment.
Doesn't this change depend on the other PR changing qjsc?
3 participants
See the referenced commits in messages.
Split from #1187