feat: Support additional custom offset in case of pinned header above…#116
Open
Ortes wants to merge 1 commit intoquire-io:masterfrom
Open
feat: Support additional custom offset in case of pinned header above…#116Ortes wants to merge 1 commit intoquire-io:masterfrom
Ortes wants to merge 1 commit intoquire-io:masterfrom
Conversation
Member
|
Hi @Ortes, This feature can actually be achieved using an alternative method. e.g. since the underlying implementation works the same way. : ) |
Author
|
Indeed it works but it does not have the exact same behavior because it scroll to the offset then backward (I put negative values because I have a pinned header above so I need to offset negatively) |
Member
|
Sorry for the late response; there was a permission issue with this repo. Regarding your case with the pinned header, is viewportBoundaryGetter sufficient for your needs? We are trying to keep the number of arguments in the interface as minimal as possible to maintain simplicity for everyone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No breaking change (I think)
Add support for addition custom offset.
.scrollToIndex()now takes an additional nullableoffsetparameter which move the final offset by this amount.