Closed
Conversation
Multiple models are indeed used plus this makes naming consistent mit other Makefiles.
kba
approved these changes
Jan 22, 2021
vahidrezanezhad
approved these changes
Jan 23, 2021
Contributor
|
I had a look on other Makefiles to check for consistency:
So I guess it's up to us how to name this. (There is resource management coming in OCR-D/core#559 but that only pertains to OCR-D.) |
Member
Author
|
I think I checked eynollah for a reference Makefile convention to use. Moreover, the current version of Anyway I understand that meanwhile @vahidrezanezhad has trained a newer and uniform model so that future versions will only require a single model file... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple models are indeed used plus this makes naming consistent with other Makefiles.