Skip to content

Conversation

@Bisaloo
Copy link
Collaborator

@Bisaloo Bisaloo commented Jul 22, 2025

Fix #2610

@codecov
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.28%. Comparing base (16ae3dc) to head (ea8ac28).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2885   +/-   ##
=======================================
  Coverage   99.28%   99.28%           
=======================================
  Files         128      129    +1     
  Lines        7231     7266   +35     
=======================================
+ Hits         7179     7214   +35     
  Misses         52       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Bisaloo Bisaloo force-pushed the all_equal_linter branch from a7111d8 to a5e900b Compare July 22, 2025 08:55
@MichaelChirico MichaelChirico added this to the 3.3.0 milestone Jul 29, 2025
@MichaelChirico
Copy link
Collaborator

MichaelChirico commented Jul 29, 2025

Found some true positives :)

ycroissant/plm#71
topepo/caret#1408

And e-mailed the {glmnet} maintainer for one finding.

@MichaelChirico
Copy link
Collaborator

Ran this on my hodgepodge repo of 6500 files in R packages and r-devel, no false positives remain. Thanks!

@MichaelChirico MichaelChirico merged commit acaa5c7 into main Jul 31, 2025
21 checks passed
@MichaelChirico MichaelChirico deleted the all_equal_linter branch July 31, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New linter for if(all.equal(...))

3 participants