Skip to content

Conversation

@AndersGM
Copy link
Contributor

@AndersGM AndersGM commented Apr 26, 2025

Updated dependencies and removed support for deprecated ruby 2.7.x

@AndersGM AndersGM force-pushed the update-dependencies branch from f10c5f4 to e3ff859 Compare April 26, 2025 07:16
@AndersGM AndersGM force-pushed the update-dependencies branch from e3ff859 to eb06763 Compare April 26, 2025 07:25
@AndersGM AndersGM force-pushed the update-dependencies branch from 49e9717 to 74574d4 Compare April 26, 2025 07:30
@AndersGM AndersGM force-pushed the update-dependencies branch from 74574d4 to 7a2f095 Compare April 26, 2025 07:31
@AndersGM
Copy link
Contributor Author

AndersGM commented May 1, 2025

@r7kamura :-)

@r7kamura
Copy link
Owner

r7kamura commented May 1, 2025

Thank you!

Dropping support for a specific Ruby version—even if it’s already deprecated—can be a significant change for existing users. For that reason, I plan to address it in a separate pull request. Also, although we haven’t explicitly specified the Ruby version in the gemspec until now, I thought this would be a good opportunity to add it as well.

@r7kamura
Copy link
Owner

r7kamura commented May 2, 2025

The reason we've been running CI on two Ruby versions so far was to ensure coverage for both the minimum supported version and the latest supported version. If we stick with this approach, we should probably include Ruby 3.0 in the CI matrix as well.

In fact, looking at the current Gemfile.lock, I suspect it might not work correctly on Ruby 3.0. I'm not very familiar with the recent state of nokogiri gem. Is it not possible to make a single Gemfile.lock work with both Ruby 3.0 and 3.4? If that's the case, then maybe we should consider maintaining separate Gemfile.lock files for each Ruby version used in CI.
What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants