Sinthavong1337/eng 254 implement a settings page for user preferences and tag#168
Open
SengdowJones wants to merge 26 commits intomainfrom
Open
Conversation
Co-authored-by: imsengdao <imsengdao@gmail.com>
Co-authored-by: imsengdao <imsengdao@gmail.com>
Co-authored-by: imsengdao <imsengdao@gmail.com>
Co-authored-by: imsengdao <imsengdao@gmail.com>
… image Co-authored-by: imsengdao <imsengdao@gmail.com>
Co-authored-by: imsengdao <imsengdao@gmail.com>
Co-authored-by: imsengdao <imsengdao@gmail.com>
Co-authored-by: imsengdao <imsengdao@gmail.com>
Co-authored-by: imsengdao <imsengdao@gmail.com>
Co-authored-by: imsengdao <imsengdao@gmail.com>
Co-authored-by: imsengdao <imsengdao@gmail.com>
Co-authored-by: imsengdao <imsengdao@gmail.com>
…tag editing UX, and improve destructive action layout
…n Edit Tag dialog
|
Pull Request Smart Comments
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request implements a comprehensive settings page for user preferences and tag management functionality. The changes introduce a new settings interface that includes appearance controls (theme selection) and a complete tag management system with CRUD operations.
- Adds a new settings page with theme selection and tag management capabilities
- Implements full CRUD operations for tags in the client library
- Creates a dedicated TagManager component with create/edit/delete functionality
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| next/src/lib/client.ts | Extends useTags hook with CRUD operations for tag management |
| next/src/components/ui/theme-toggle.tsx | Adds ThemeSelector component for theme preference selection |
| next/src/components/TagManager.tsx | New component providing comprehensive tag management UI |
| next/src/components/OutfitSuggestions.tsx | Updates Tag component usage with compact prop |
| next/src/components/AuthenticatedHeader.tsx | Replaces theme toggle with settings navigation link |
| next/src/app/(authenticated)/settings/page.tsx | New settings page with appearance and tag management sections |
| next/next.config.mjs | Adds Clerk image domain to remote patterns for user avatars |
| hono/package.json | Updates @hono/clerk-auth dependency version |
Files not reviewed (1)
- hono/package-lock.json: Language not supported
Comments suppressed due to low confidence (1)
next/src/components/TagManager.tsx:276
- The color selection buttons should include keyboard navigation support. Consider adding
onKeyDownhandlers for Enter and Space keys to improve accessibility.
/>
rak3rman
requested changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.