fix: prevent React DOM error when using browser translation #897
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: prevent React DOM error when browser translation modifies ScreenReaderOutput
This pull request:
Fixes #896
Problem
When using browser translation on
/primitivesand scrolling to the "Accessibility out of the box" section, the following error occurs:This happens because browser translation modifies the DOM structure, and when React tries to conditionally render different
<span>elements inScreenReaderOutput, it conflicts with the translated DOM.Solution
Instead of conditionally rendering different elements based on
dropdownState, render all text items simultaneously and control visibility with CSSdisplay: none. This prevents React from adding or removing DOM nodes, avoiding conflicts with browser translation.Testing
pnpm devhttp://localhost:3000/primitives