Metrics plugin by Sharpz7 · Pull Request #132 · radoss-org/retuve

Sharpz7 · 2025-09-20T03:45:57Z

No description provided.

Copilot

Pull Request Overview

This PR implements a comprehensive "Metrics plugin" system that adds support for custom metrics and preprocessing functions in the hip ultrasound analysis pipeline. The changes introduce pluggable architecture for extending the analysis capabilities.

Adds custom metric functions and segmentation preprocessing hooks to the HipConfig
Implements line extension algorithm for improved point positioning calculations
Enhances drawing system with polynomial-based smooth skeleton rendering and improved error handling

Reviewed Changes

Copilot reviewed 22 out of 23 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
retuve/keyphrases/subconfig.py	Adds full_metric_functions and seg_preprocess_functions parameters to HipConfig
retuve/funcs.py	Implements plugin execution logic for custom metrics and preprocessing functions
retuve/utils.py	Extends point_left_right function with 1000-pixel line extension algorithm
retuve/classes/draw.py	Enhances skeleton drawing with polynomial fitting for smooth curves
retuve/hip_us/modes/seg.py	Updates segs_2_landmarks_us to return ilium angle baselines
retuve/hip_us/metrics/alpha.py	Modifies find_alpha_landmarks to calculate and return angle baseline
retuve/hip_us/multiframe/graf.py	Replaces global DO_CALIBRATION with config-based do_calibration
retuve/hip_us/classes/dev.py	Adds average_ilium_angle_baseline field to DevMetricsUS

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

retuve/keyphrases/subconfig.py

retuve/utils.py

retuve/hip_us/multiframe/graf.py

retuve/classes/draw.py

retuve/funcs.py

Sharpz7 · 2025-09-20T23:33:53Z

retuve/classes/draw.py

                fill=self.config.hip.midline_color.rgba(),
            )

+        if len(skel) < 2:


Need to try and simplify this

Sharpz7 · 2025-09-20T23:35:03Z

retuve/hip_us/metrics/dev.py

+
+    # Merge any custom dev metrics collected earlier (e.g., from full_metric_functions)
+    try:
+        if hasattr(hip_datas, "dev_metrics_custom") and hip_datas.dev_metrics_custom:


We should remove these hasattr's in favor of a proper object

Sharpz7 · 2025-09-20T23:35:16Z

retuve/hip_us/modes/landmarks.py

 from retuve.logs import log_timings


+def _polyfit_replace_apex(


This is insanely long

Sharpz7 · 2025-09-20T23:36:07Z

retuve/hip_us/multiframe/main.py

                )
            )

+    # Also aggregate any custom per-frame metric function outputs


Should be its own function, maybe we put all the custom stuff in its own file?

Sharpz7 · 2025-09-20T23:36:17Z

retuve/hip_us/draw.py

            graf_conf,
        )

+        # Run any custom post-draw hooks after base drawing (standard signature)


Own function

Sharpz7 · 2025-09-20T23:36:33Z

retuve/hip_xray/classes.py

        self.frame_no: int = None
        self.recorded_error: RecordedError = RecordedError()

+    def get_metric(self, name: str):


This does not seem nessasary

Actually, I think we have this for the Ultrasound equivalent so maybe it stays?

Sharpz7 · 2025-09-20T23:36:49Z

retuve/hip_xray/draw.py

        overlay = draw_ihdi(final_hip, overlay, config)
        overlay = draw_tonnis(final_hip, overlay, config)

+        # Run any custom post-draw hooks after base drawing (standard signature)


Own function, the __name__'s scare me

Sharpz7 · 2025-09-20T23:37:06Z

retuve/funcs.py

    hip_datas_xray = landmarks_2_metrics_xray(landmark_results, config)
+
+    # Run custom per-image metric functions (standardized signature)
+    per_frame_funcs = getattr(config.hip, "per_frame_metric_functions", []) or []


Own function

Sharpz7 · 2025-09-20T23:37:13Z

retuve/funcs.py

    results, shape = pre_process_segs_us(results, config)
+
+    # Run any custom segmentation pre-process hooks
+    for preprocess in getattr(config.hip, "seg_preprocess_functions", []) or []:


Own function

Sharpz7 · 2025-09-20T23:37:24Z

retuve/funcs.py

+    hip_datas.ilium_angle_baselines = ilium_angle_baselines
+
+    # Initialize a container for any custom dev metrics returned by full_metric_functions
+    if (


Own function / We should remove these hasattr's in favor of a proper object

Sharpz7 · 2025-09-20T23:37:55Z

retuve/utils.py

    x2, y2 = p2
    x3, y3 = p3

+    # Extend the line segment by 1000 pixels in both directions


There has to be a way to make this code more consise

Sharpz7 · 2025-09-20T23:38:12Z

tests/fixtures/unit.py

    metrics_2dus = {}
-    for _dict in metrics_2d_us["metrics"]:
-        metrics_2dus.update(_dict)
+    for item in metrics_2d_us["metrics"]:


Own function, maybe apply DRY when we have all this together

Sharpz7 · 2025-09-23T05:41:18Z

changenotes/2025-09-22_title-here.yaml

+    dev_metrics: {}
+  us_sweep:
+    metrics:
+    - Metric2D(name=alpha, value=69.2)  # Modified


This is a bug that needs fixed

Sharpz7 · 2025-09-23T05:41:25Z

changenotes/2025-09-22_title-here.yaml

@@ -0,0 +1,88 @@
+description: Your description here.


Need to fill this in

Signed-off-by: Sharpz7 <adam.mcarthur62@gmail.com>

codecov · 2025-09-23T06:06:28Z

Codecov Report

❌ Patch coverage is 51.36612% with 178 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
retuve/funcs.py	36.44%	49 Missing and 19 partials ⚠️
retuve/hip_us/modes/landmarks.py	6.25%	29 Missing and 1 partial ⚠️
retuve/defaults/hip_configs.py	72.22%	12 Missing and 3 partials ⚠️
retuve/hip_xray/draw.py	30.00%	12 Missing and 2 partials ⚠️
retuve/batch.py	0.00%	9 Missing and 1 partial ⚠️
retuve/classes/draw.py	74.07%	6 Missing and 1 partial ⚠️
retuve/hip_us/metrics/dev.py	40.00%	5 Missing and 1 partial ⚠️
retuve/hip_xray/classes.py	40.00%	4 Missing and 2 partials ⚠️
retuve/hip_us/multiframe/graf.py	33.33%	2 Missing and 2 partials ⚠️
retuve/hip_us/multiframe/main.py	71.42%	1 Missing and 3 partials ⚠️
... and 8 more

📢 Thoughts on this report? Let us know!

cursor · 2025-10-09T19:01:09Z

retuve/hip_us/draw.py

+            except Exception as e:
+                ulogger.error(
+                    f"Post-draw function {getattr(func, '__name__', str(func))} failed: {e}"
+                )


Bug: Unexpected Argument in Custom Draw Functions

The draw_hips_us function passes an extra seg_frame_objs argument to custom post_draw_functions. These functions are designed to accept (hip, overlay, config), so the argument mismatch will cause TypeError when invoked.

cursor · 2025-10-09T19:01:10Z

retuve/funcs.py

+
+    if getattr(hip_datas, "custom_metrics", None) is not None:
+        graf_hip.metrics += hip_datas.custom_metrics
+


Bug: Appending List to Dictionary Causes Error

graf_hip.metrics is initialized as a dictionary on line 663, but the code later attempts to append a list of metrics to it using +=. This type mismatch causes a TypeError.

Sharpz7 · 2025-10-17T19:16:16Z

retuve/hip_xray/draw.py

+
+        # Fallback: draw values of registered per-frame metrics if present
+        # Only run this fallback when there are NO custom post-draw hooks to avoid duplicates
+        per_frame_funcs = getattr(config.hip, "per_frame_metric_functions", []) or []


This is a pointless fallback

Sharpz7 added 9 commits September 15, 2025 00:33

Adding changes

3e97603

Merge https://github.com/radoss-org/retuve into metrics-plugin

fde6043

Initial Commit

07a1799

savestate

f495a07

savestate

ee83963

X-Ray Changes

978eefc

Merge https://github.com/radoss-org/retuve into metrics-plugin

94aa689

Merge branch 'calibration' into metrics-plugin

93cb87b

More changes

af642ca

Copilot AI review requested due to automatic review settings September 20, 2025 03:45

Copilot AI reviewed Sep 20, 2025

View reviewed changes

Sharpz7 added 2 commits September 19, 2025 23:24

Some bug fixes, still needs tested

2cd78d5

Added more changes

0399054

Sharpz7 commented Sep 20, 2025

View reviewed changes

retuve/hip_us/modes/landmarks.py

from retuve.logs import log_timings

def _polyfit_replace_apex(

Copy link

Contributor Author

Sharpz7 Sep 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is insanely long

Sharpz7 commented Sep 20, 2025

View reviewed changes

retuve/hip_us/draw.py

graf_conf,

)

# Run any custom post-draw hooks after base drawing (standard signature)

Copy link

Contributor Author

Sharpz7 Sep 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Own function

Sharpz7 commented Sep 20, 2025

View reviewed changes

Fixed tests

37ebe17

Sharpz7 commented Sep 23, 2025

View reviewed changes

changenotes/2025-09-22_title-here.yaml

@@ -0,0 +1,88 @@

description: Your description here.

Copy link

Contributor Author

Sharpz7 Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fill this in

This comment was marked as outdated.

Sign in to view

Fixed formatting

2ed8d87

Signed-off-by: Sharpz7 <adam.mcarthur62@gmail.com>

Test fixes

3385f96

This comment was marked as outdated.

Sign in to view

Sharpz7 added 2 commits September 22, 2025 23:58

Added bugfix

b134919

bugfixes

d031248

More changes

71e1229

This comment was marked as outdated.

Sign in to view

Savestate

d58af49

cursor bot reviewed Oct 9, 2025

View reviewed changes

Sharpz7 commented Oct 17, 2025

View reviewed changes

Sharpz7 added 3 commits October 22, 2025 13:36

Changes

4b66e15

Added fixes

ec860b3

more changes

fb1fdbd

		from retuve.logs import log_timings


		def _polyfit_replace_apex(


		if getattr(hip_datas, "custom_metrics", None) is not None:
		graf_hip.metrics += hip_datas.custom_metrics

Conversation

Sharpz7 commented Sep 20, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Sharpz7 Sep 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

codecov bot commented Sep 23, 2025

Codecov Report

Uh oh!

This comment was marked as outdated.

Uh oh!

cursor bot Oct 9, 2025

Choose a reason for hiding this comment

Bug: Unexpected Argument in Custom Draw Functions

Uh oh!

cursor bot Oct 9, 2025

Choose a reason for hiding this comment

Bug: Appending List to Dictionary Causes Error

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Sharpz7 Sep 20, 2025 •

edited

Loading