Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MooseX::LazyRequire was recommended to me on #moose, but I failed to understand how it worked because I read the synopsis too hastily. (I think I thought the second attribute also had a lazy requirement, which clearly would never work as you'd end up with an endless loop, but I never got to think myself to that point.) I think a clearer explanation of why the constructor fails would possibly help others in similar situations.
Even if it doesn't, I don't think there would be any harm.
Much more trivially, but also far more clearly wrong, there was a typo which I've also corrected ;-) .