Skip to content

Optimization: prevent empty COMMIT calls #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chaffeqa wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Optimization: prevent empty COMMIT calls #166

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc5699d
Optimization: prevent empty COMMIT calls
chaffeqa Oct 24, 2020
09fd2f6
Update active_record_store.rb
chaffeqa May 3, 2021
6370b60
Merge branch 'rails:master' into patch-1
chaffeqa Jun 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/action_dispatch/session/active_record_store.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def write_session(request, sid, session_data, options)
logger.silence do
record, sid = get_session_model(request, sid)
record.data = session_data
return false unless record.save
return sid if record.changed? and not record.save

session_data = record.data
if session_data && session_data.respond_to?(:each_value)
Expand Down