Assign Net::HTTPRequest to exceptions
#471
Open
+73
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
force-pushed
the
exception-request
branch
3 times, most recently
from
daccadd to
cd7b484
Compare
With the changes made in [2ea5401][], the underlying [Net::HTTPRequest][] instance is available to the connection throughout the lifetime of the request. With that instance available, exceptions raised during the request-response handshake can be constructed with the `Net::HTTPRequest` instance. Access to the `Net::HTTPRequest` from code that rescues from those exceptions is valuable: * for debugging purposes * for observability and logging * for retrying requests, etc. However, the exception classes are documented and therefore their constructors are part of the public API. Inserting a `request` positional argument is a breaking change. To account for that, this commit includes deprecations for subclasses that call `super` from within `#initialize` to instruct them on changing the signature to account for the `Net::HTTPRequest` instance. [2ea5401]: rails@2ea5401 [Net::HTTPRequest]: https://docs.ruby-lang.org/en/master/Net/HTTPRequest.html
seanpdoyle
force-pushed
the
exception-request
branch
from
cd7b484 to
a051e7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the changes made in 2ea5401, the underlying Net::HTTPRequest instance is available to the connection throughout the lifetime of the request. With that instance available, exceptions raised during the request-response handshake can be constructed with the
Net::HTTPRequestinstance.Access to the
Net::HTTPRequestfrom code that rescues from those exceptions is valuable:However, the exception classes are documented and therefore their constructors are part of the public API. Inserting a
requestpositional argument is a breaking change. To account for that, this commit includes deprecations for subclasses that callsuperfrom within#initializeto instruct them on changing the signature to account for theNet::HTTPRequestinstance.