Check integrations to avoid showing error messages #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 20, 2016 11:50
A lot of error messages showed up in my case when I set up my first project. This was not the best experience, for non-programmers the errors might be even more misleading.
Otherwise we would need to check if histories is already initialized when looping through the histories entries. As for game projects there are even no histories used by default, so the user instantly gets an error message.
This provides a more clear roadmap what to do and avoids unnecessary error messages along the way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As for now the experience with setting up a project was quite bad for me. I got quite a lot of error messages I was not to blame for.
With the code changes, sheet.php will now check whether or not promoter is used and if there is an integration of distribute. Additionally histories in the game project are no longer required (Which is the standard case according to the data.xml file in _template) and an image folder is added to the template folder during the installation.