Skip to content

Harden default Drupal scaffold file permissions #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
doxigo wants to merge 1 commit into
base: 11.x
Choose a base branch
from
Open

Harden default Drupal scaffold file permissions #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions scripts/composer/ScriptHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,16 @@
*/
class ScriptHandler {

/**
* Default permission for settings.php.
*/
private const SETTINGS_FILE_MODE = 0644;

/**
* Default permission for public files directory.
*/
private const PUBLIC_FILES_DIRECTORY_MODE = 0775;

/**
* Creates required Drupal directories and files to ensure proper installation.
*
Expand Down Expand Up @@ -65,16 +75,16 @@ public static function createRequiredFiles(Event $event) {
'required' => TRUE,
];
SettingsEditor::rewrite($drupalRoot . '/sites/default/settings.php', $settings);
$fs->chmod($drupalRoot . '/sites/default/settings.php', 0666);
$event->getIO()->write("Created a sites/default/settings.php file with chmod 0666");
$fs->chmod($drupalRoot . '/sites/default/settings.php', self::SETTINGS_FILE_MODE);
$event->getIO()->write(sprintf('Created a sites/default/settings.php file with chmod %04o', self::SETTINGS_FILE_MODE));
}

// Create the files directory with chmod 0777.
// Create the files directory with group-writable permissions.
if (!$fs->exists($drupalRoot . '/sites/default/files') && !is_link($drupalRoot . '/sites/default/files')) {
$oldmask = umask(0);
$fs->mkdir($drupalRoot . '/sites/default/files', 0777);
$fs->mkdir($drupalRoot . '/sites/default/files', self::PUBLIC_FILES_DIRECTORY_MODE);
umask($oldmask);
$event->getIO()->write("Created a sites/default/files directory with chmod 0777");
$event->getIO()->write(sprintf('Created a sites/default/files directory with chmod %04o', self::PUBLIC_FILES_DIRECTORY_MODE));
}
}

Expand Down