This repository was archived by the owner on Dec 8, 2023. It is now read-only.
Updated parted args to correctly grow the partition to 100%#833
Open
sameersbn wants to merge 1 commit intorancher:masterfrom
Open
Updated parted args to correctly grow the partition to 100%#833sameersbn wants to merge 1 commit intorancher:masterfrom
sameersbn wants to merge 1 commit intorancher:masterfrom
Conversation
The parted command wasn't resizing the root partition to use the available disk space. The issue in parted is also documented in the bug report https://bugs.launchpad.net/ubuntu/+source/parted/+bug/1270203. In this PR the invocation of the `parted` command has been updated so that the partition is properly resized to used the available disk space.
liyimeng
suggested changes
Jan 24, 2022
Contributor
liyimeng
left a comment
liyimeng
left a comment
There was a problem hiding this comment.
why don't use -s to run parted in script mode instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parted command wasn't resizing the root partition to use the available disk space. The issue in parted is also documented in the bug report https://bugs.launchpad.net/ubuntu/+source/parted/+bug/1270203.
In this PR the invocation of the
partedcommand has been updated so that the partition is properly resized to use the available disk space.This works for parted 3.4 which is what's present in the current pre-release version (
v0.22.2-k3s2r0) of k3os. In the release version (v0.21.5-k3s2r1) however the parted version is 3.3 and requires a slight modification in the command:In case there are further maintenance releases planned for the
v0.21.5series then we should update the line to