Conditionally include vSphere cloud provider secret config#2128
Closed
nikkelma wants to merge 1 commit intorancher:masterfrom
Closed
Conditionally include vSphere cloud provider secret config#2128nikkelma wants to merge 1 commit intorancher:masterfrom
nikkelma wants to merge 1 commit intorancher:masterfrom
Conversation
Author
|
Is this the entire set of changes needed to support these two fields introduced in v1.11? Unsure if the in-tree or out-of-tree cloud provider is used. |
nikkelma
changed the title
…ntials if provided
nikkelma
force-pushed
the
vsphere-cloud-provider-secret
branch
from
7d1f8ab to
a1bf4ab
Compare
|
This issue/PR has been automatically marked as stale because it has not had activity (commit/comment/label) for 60 days. It will be closed in 14 days if no further activity occurs. Thank you for your contributions. |
|
This issue/PR has been automatically marked as stale because it has not had activity (commit/comment/label) for 60 days. It will be closed in 14 days if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include vSphere cloud provider secret config instead of literal credentials if provided. Depends on rancher/types#1165.