This repository was archived by the owner on Mar 25, 2024. It is now read-only.
OpenStack: support lbaas classes (FIP subnet IDs)#986
Open
kayrus wants to merge 1 commit intorancher:masterfrom
Open
OpenStack: support lbaas classes (FIP subnet IDs)#986kayrus wants to merge 1 commit intorancher:masterfrom
kayrus wants to merge 1 commit intorancher:masterfrom
Conversation
Author
|
@dramich could you please assign someone on this PR? |
Author
|
@alena1108 could you please assign someone on this PR? |
Author
|
@dramich @alena1108 kindly ping |
daxmc99
suggested changes
Nov 27, 2019
Contributor
daxmc99
left a comment
daxmc99
left a comment
There was a problem hiding this comment.
Please reach out to me in the rancher slack developer channel. For types changes we typically require an equivalent change in RKE/Rancher with a go.mod replace directive such that the changes can run against our CI.
| // DeepCopyInto is an autogenerated deepcopy function, copying the receiver, writing into out. in must be non-nil. | ||
| func (in *LoadBalancerOpenstackOpts) DeepCopyInto(out *LoadBalancerOpenstackOpts) { | ||
| *out = *in | ||
| if in.LBClasses != nil { |
Contributor
There was a problem hiding this comment.
This is generated code and this looks like a hand edit. This will be overwritten.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the rancher/rancher#23020