feat: migrated tonconnect to the hub #1344
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llawliet-l-l
force-pushed
the
feat/rf-2840-migrating-tonconnect-to-hub
branch
from
389b1ea to
59d7c07
Compare
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| export type ProviderAPI = Record<string, any>; | ||
|
|
||
| export type ConnectOptions = { |
Contributor
There was a problem hiding this comment.
Remove it since it's not being using.
| @@ -0,0 +1,2 @@ | |||
| export const CAIP_NAMESPACE = 'ton'; | |||
Contributor
There was a problem hiding this comment.
Change it according to CAIP
llawliet-l-l
force-pushed
the
feat/rf-2840-migrating-tonconnect-to-hub
branch
from
501dbde to
74a5840
Compare
| return async (context) => { | ||
| const tonInstance = getInstance(); | ||
| await tonInstance.disconnect(); | ||
| commonActions.disconnect(context); |
Contributor
There was a problem hiding this comment.
Do it separately in a and added to its action builder.
Comment on lines
29
to
31
| const disconnect = new ActionBuilder<TonActions, 'disconnect'>('disconnect') | ||
| .action(tonActions.disconnect(tonConnect)) | ||
| .after(changeAccountCleanup) | ||
| .build(); |
Contributor
There was a problem hiding this comment.
Use disconnect from common builders
Comment on lines
9
to
36
| const changeAccountSubscriber = (getInstance: () => TonConnectUI) => | ||
| new ChangeAccountSubscriberBuilder< | ||
| ConnectedWallet | null, | ||
| TonConnectUI, | ||
| TonActions | ||
| >() | ||
| .getInstance(getInstance) | ||
| /* | ||
| * TON wallets don't implement account change events, and we can only listen to disconnect events | ||
| * by checking the payload value. | ||
| * More info: https://github.com/ton-blockchain/ton-connect/blob/main/wallet-guidelines.md | ||
| */ | ||
| .onSwitchAccount(async (event, context) => { | ||
| event.preventDefault(); | ||
| if (!event.payload) { | ||
| commonActions.disconnect(context); | ||
| } | ||
| }) | ||
| .format(async () => []) | ||
| .addEventListener((instance, callback) => { | ||
| return instance.onStatusChange(callback); | ||
| }) | ||
| .removeEventListener(() => { | ||
| /* | ||
| * We handle unsubscribing in the builder and by returning an unsubscribe function from 'addEventListener' | ||
| */ | ||
| }); | ||
|
|
Contributor
There was a problem hiding this comment.
Don't use change account subscriber builder for disconnect use another disconnect handler.
| ): FunctionWithContext<TonActions['disconnect'], Context> { | ||
| return async (context) => { | ||
| const tonInstance = getInstance(); | ||
| await tonInstance.disconnect(); |
Contributor
There was a problem hiding this comment.
Check if it's been disconnected don't disconnect again
# Conflicts: # wallets/core/package.json # wallets/core/src/hub/provider/types.ts # wallets/react/src/hub/helpers.ts # wallets/readme.md # Conflicts: # wallets/provider-all/src/index.ts # wallets/readme.md
llawliet-l-l
force-pushed
the
feat/rf-2840-migrating-tonconnect-to-hub
branch
from
20aafa5 to
21647c9
Compare
llawliet-l-l
force-pushed
the
feat/rf-2840-migrating-tonconnect-to-hub
branch
from
21647c9 to
64f5f2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added Ton builders, utils and types to the wallets core.
Migrated TonConnect to use the new hub APIs for ton namespaces and updated documentation:
How did you test this change?
TonConnect was tested end-to-end within the Hub environment:
Checklist: