fix: address getting for cosmos chains with null info #1345
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where users were unable to generate addresses for certain Cosmos chains (e.g. Rune) when using wallets like Cosmostation, Keplr, and Leap.
The problem was caused by the experimental-chain detection logic. We were first checking for the existence of
chain.info, and then readinginfo.experimental. For some chains,infocan benull, which caused them to be incorrectly treated as experimental and blocked from address generation.This change updates the logic to assume chains with
info === nullare non-experimental, and only treat a chain as experimental wheninfo.experimental === true.Fixes # (issue)
How did you test this change?
info === null(e.g. Rune)Checklist:
If you want, I can also: