chore: check trustline using new 'preconidtions' data from backend #1358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeager-eren
commented
Jan 6, 2026
|
|
||
| const hasAlreadyProceededToSign = | ||
| typeof swap.hasAlreadyProceededToSign === 'boolean'; | ||
| const hasAlreadyProceededToSign = !!swap.hasAlreadyProceededToSign; |
Collaborator
Author
There was a problem hiding this comment.
this is important change. if hasAlreadyProceededToSign was false, the old check was changing it to true at the end.
yeager-eren
commented
Jan 6, 2026
| setTransactionDataByHash(hash, { response }); | ||
| } | ||
| const { schedule, next } = actions; | ||
| updateStorageOnSuccessfulSign(actions, { hash, response }, data); |
Collaborator
Author
There was a problem hiding this comment.
the problem here was handleSuccessfulSign always schedule CHECK_TRANSACTION_STATUS as next step but in check trustline the next step is EXECUTE_XRPL_TRANASCTION.
yeager-eren
force-pushed
the
chore/rf-add-check-trust-line-using-preconidtions
branch
from
e9a6a08 to
df4988c
Compare
yeager-eren
commented
Jan 6, 2026
| } else { | ||
| schedule(SwapActionTypes.EXECUTE_TRANSACTION); | ||
| } | ||
| schedule(SwapActionTypes.SCHEDULE_NEXT_STEP); |
Collaborator
Author
There was a problem hiding this comment.
important change. ensure doesn't affect the non-xrpl flow.
yeager-eren
force-pushed
the
chore/rf-add-check-trust-line-using-preconidtions
branch
from
df4988c to
bbe622a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
َUsing
preconditionsfrom server and make checking the trustline a separate step.In the first implementation we were checking a user needs a trustline or not in client. there are some cases for the determining the trustline should be open first are hard, e.g. bridge a token into xrpl and a non-native token. we handed over this to server, now each transaction has a
preconditionsfield which tell us to run the actual transaction what we need to first do. so here we are using this new approach.Another change is make the check of trustline a separate step to break the process into smaller steps and in future we can integrate stellar more easily and also evm approvals.
Fixes RF-2294
Part of #1096
Blocked by rango-exchange/rango-types#57
How did you test this change?
you can test in #1096
do some transactions as followed:
Checklist: