Fix loop termination bug in Tutorial 07 (Code + Docs)#67
Open
Agents-swarm-it wants to merge 2 commits intoraphaelmansuy:mainfrom
Open
Fix loop termination bug in Tutorial 07 (Code + Docs)#67Agents-swarm-it wants to merge 2 commits intoraphaelmansuy:mainfrom
Agents-swarm-it wants to merge 2 commits intoraphaelmansuy:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The loop was incorrectly hitting max_iterations because the code used end_of_agent = True. This command successfully stopped the Refiner (the child agent), but failed to signal the parent RefinementLoop to terminate.
I have updated both agent.py and the documentation (07_loop_agents.md) to use escalate = True. This ensures the stop signal propagates up to the LoopAgent, allowing it to exit early as intended.
Evidence of bug:
