Adds a shared pipeline for gems verify workflow#20001
Merged
adfoster-r7 merged 1 commit intorapid7:masterfrom Apr 9, 2025
Merged
Adds a shared pipeline for gems verify workflow#20001adfoster-r7 merged 1 commit intorapid7:masterfrom
adfoster-r7 merged 1 commit intorapid7:masterfrom
Conversation
2 tasks
This was referenced Apr 3, 2025
be6ff3d to
f7b2c92
Compare
adfoster-r7
reviewed
Apr 4, 2025
a68e8ea to
cabf58f
Compare
Contributor
|
Just an opinion here, this seems to create a circular dependency in the github actions where sub-gems repos are now dependent on the state of a repo that consumes them. It might be better to create a repo that holds |
a2b230c to
ea63928
Compare
86698c3 to
afa30d0
Compare
Contributor
|
@jmartin-tech Thanks! I also think having it in a centralized repo could also reduce the checkout time for faster CI runs by a bit, but we'll keep things simple as a first pass and can revisit it if there's any issues with future upgrade efforts 🤞 |
afa30d0 to
81aa4be
Compare
adfoster-r7
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two new shared pipelines for testing gems. One for testing gems with Rails and another for without. The idea here was to now have one centralized point of truth for testing our gems.
The shared pipeline will support inputs for dependencies and testing commands e.g.
Initially the corresponding gem PRs will point at these new pipelines on my @cgranleese-r7 repository for testing. Once this is landed, I will rebase those PRs.
Gems PRs:
Verification