Skip to content

Comments

Revert "Adds network capture decryption support to http scanners"#20114

Merged
adfoster-r7 merged 1 commit intomasterfrom
revert-20080-adds-http-support-for-network-capture-decryption
May 1, 2025
Merged

Revert "Adds network capture decryption support to http scanners"#20114
adfoster-r7 merged 1 commit intomasterfrom
revert-20080-adds-http-support-for-network-capture-decryption

Conversation

@cgranleese-r7
Copy link
Contributor

@cgranleese-r7 cgranleese-r7 commented May 1, 2025

Reverts #20080 due to issues only found once merged and CI tested both Postgres and LDAP.

LDAP failures:

[read] ��msf6�� auxiliary(����scanner/ldap/ldap_login��) ��> 
[write] run PASS_FILE= USER_FILE= CreateSession=true ldapusername='DEV-AD\Administrator' ldappassword=admin123! rhost=127.0.0.1 rport=389 ssl=false
[read] [-] Auxiliary failed: NoMethodError undefined method `sslkeylogfile=' for #<Metasploit::Framework::LoginScanner::LDAP:0x00007f3d0d9941b0 @host="127.0.0.1", @port=389, @proxies=nil, @stop_on_success=false, @bruteforce_speed=5>
[read] [-] Call stack:
[read] [-]   /home/runner/work/metasploit-framework/metasploit-framework/lib/metasploit/framework/login_scanner/base.rb:86:in `public_send'
[read] [-]   /home/runner/work/metasploit-framework/metasploit-framework/lib/metasploit/framework/login_scanner/base.rb:86:in `block in initialize'
[read] [-]   /home/runner/work/metasploit-framework/metasploit-framework/lib/metasploit/framework/login_scanner/base.rb:85:in `each'
[read] [-]   /home/runner/work/metasploit-framework/metasploit-framework/lib/metasploit/framework/login_scanner/base.rb:85:in `initialize'
[read] [-]   /home/runner/work/metasploit-framework/metasploit-framework/modules/auxiliary/scanner/ldap/ldap_login.rb:1[40](https://github.com/rapid7/metasploit-framework/actions/runs/14773815518/job/41478398437#step:7:41):in `new'
[read] [-]   /home/runner/work/metasploit-framework/metasploit-framework/modules/auxiliary/scanner/ldap/ldap_login.rb:140:in `run_host'
[read] [-]   /home/runner/work/metasploit-framework/metasploit-framework/lib/msf/core/auxiliary/scanner.rb:116:in `block (2 levels) in run'
[read] [-]   /home/runner/work/metasploit-framework/metasploit-framework/lib/msf/core/thread_manager.rb:105:in `block in spawn'
[read] [*] Auxiliary module execution completed

Copy link
Contributor

@adfoster-r7 adfoster-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failure seems unrelated:

[read] [-] FAILED: should accept spaces in the filename and return the create_process output

@adfoster-r7 adfoster-r7 added the rn-no-release-notes no release notes label May 1, 2025
@adfoster-r7 adfoster-r7 merged commit 79c0fd6 into master May 1, 2025
110 of 111 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rn-no-release-notes no release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants