Merged
Conversation
adfoster-r7
approved these changes
Feb 11, 2026
Contributor
Release NotesImproves the stability of socket channeling support for SSH sessions opened via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a couple of errors in the
post/test/socket_channelstests (added in #20689 for context). UDP tests are skipped because the SSH RFC doesn't support UDP channels. One TCP client test is failing, the one where binding to port 0 should allow the target to specify the port and return the value. RFC 4254 section 7.2 doesn't make any note of how the originator IP and port should be handled in this context. The way Rex::Parameters#localport is written prevents checking if port 0 was explicitly set or not. If it was explicitly set and that could be detected, an error should be thrown but that doesn't seem possible.At this point, all the tests that should pass, are passing for SSH sessions.
Verification
msfconsoleuse auxiliary/scanner/ssh/ssh_loginto open an SSH session, make sure CreateSession is true and the target server permits the necessary forwarding options in the OpenSSH configloadpath test/modulespost/test/socket_channelsOld and Broken
New and Fixed