Add install active directory install command#24
Open
adfoster-r7 wants to merge 2 commits intorapid7:masterfrom
Open
Add install active directory install command#24adfoster-r7 wants to merge 2 commits intorapid7:masterfrom
adfoster-r7 wants to merge 2 commits intorapid7:masterfrom
Conversation
adfoster-r7
commented
Mar 17, 2023
jmartin-tech
reviewed
May 2, 2023
Contributor
jmartin-tech
left a comment
There was a problem hiding this comment.
This looks like a great add.
Sorry this got delayed, more testing is in progress. Posting a couple initial thoughts.
b17af3a to
5a43e3b
Compare
5a43e3b to
3bba31d
Compare
jmartin-tech
approved these changes
May 18, 2023
Contributor
jmartin-tech
left a comment
There was a problem hiding this comment.
Testing looks good, just the one question here about using a hardcoded configuration password.
|
|
||
| # Configuration | ||
| $domain = "demo.local" | ||
| $plaintextPassword = "vagrant" |
Contributor
There was a problem hiding this comment.
Should this get the VM password from the launch config for manageServices.py? I don't mind a hardcode value however I that is not super friendly to the those that may want to have at least some security in the testing env.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds install active directory command script to vm-automation; which allows for testing Kerberos/AD environments
My testing steps were running this script locally against a windows 2016/2019 server box. Will be used by https://github.com/rapid7/metasploit-jenkins-jobs/pull/449
I then tested it with vmware-automation project by first building the metasploit-baseline-builder docker container:
Creating an ESXi config in
~/helper_config.json:Running a docker container from the Jenkins user, mounting vmware-automation and the esxi config:
Inside the running docker instance I had to install pip:
Verifying the action is available (change the prefix):
Running the action with hard coded user/password values against the target machine (change the prefix):
View the log files: