Skip to content

Conversation

@norkans7
Copy link
Contributor

@norkans7 norkans7 commented Dec 16, 2025

migrated using uvx migrate-to-uv

Copilot AI review requested due to automatic review settings December 16, 2025 10:40
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.79%. Comparing base (61bd1ce) to head (0f29210).

Additional details and impacted files
@@              Coverage Diff               @@
##           ci-containers     #115   +/-   ##
==============================================
  Coverage          99.79%   99.79%           
==============================================
  Files                  9        9           
  Lines               1451     1451           
==============================================
  Hits                1448     1448           
  Misses                 3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the project from Poetry to uv as the Python package manager, modernizing the dependency management and build system configuration. The changes replace Poetry-specific configurations with standard PEP 517/518 build system declarations and PEP 735 dependency groups, while updating the CI workflow to use uv commands.

Key Changes:

  • Replaced Poetry with hatchling as the build backend and uv for dependency management
  • Migrated from Poetry's lock file format to uv's lock file format
  • Updated GitHub Actions CI workflow to use uv commands instead of Poetry

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.

File Description
uv.lock New lock file generated by uv containing all dependency specifications and metadata
pyproject.toml Migrated from Poetry configuration to standard PEP 517/518 format with hatchling build backend and PEP 735 dependency groups
poetry.lock Removed Poetry lock file (no longer needed)
.github/workflows/ci.yml Updated CI workflow to install and use uv instead of Poetry for all package management operations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


- name: Initialize environment
run: poetry install
run: uv sync --locked --all-extras --dev
Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command uses both "--all-extras" and "--dev" flags, but the project doesn't define any optional dependencies (extras) in pyproject.toml - only a "dev" dependency group. The "--all-extras" flag is unnecessary here. Additionally, "--dev" is deprecated in favor of dependency groups. The command should be simplified to "uv sync --locked" or explicitly use "uv sync --locked --all-groups" if you want to be explicit about syncing all dependency groups.

Suggested change
run: uv sync --locked --all-extras --dev
run: uv sync --locked --all-groups

Copilot uses AI. Check for mistakes.
@norkans7 norkans7 force-pushed the switch-uv branch 2 times, most recently from 30f4d89 to d92f8cf Compare December 16, 2025 10:54
name = "rapidpro-python"
version = "2.21.0"
description = "Python client library for the RapidPro API"
authors = [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

migrated using uvx migrate-to-uv

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

poetry build
poetry config pypi-token.pypi ${{ secrets.PYPI_TOKEN }}
poetry publish
python -m pip install -U pip uv
Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release job installs uv via pip but doesn't use the setup-uv action like the test job does. For consistency and to follow best practices, consider using the astral-sh/setup-uv action here as well. If uv is installed via pip, there may be potential version mismatches or unexpected behavior compared to using the official setup action. Additionally, the release job might benefit from running 'uv sync --locked' before building to ensure a consistent build environment.

Copilot uses AI. Check for mistakes.
@norkans7 norkans7 force-pushed the ci-containers branch 2 times, most recently from 652391e to 375dfdb Compare December 17, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants