Enable CrossFit to work without Dask#127
Open
sarahyurick wants to merge 10 commits intorapidsai:mainfrom
Open
Conversation
Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>
sarahyurick
commented
May 28, 2025
Collaborator
Author
sarahyurick
left a comment
sarahyurick
left a comment
There was a problem hiding this comment.
I do not expect this to decouple Dask from CrossFit in every possible functionality. What I have tested is that it works for NeMo Curator's QualityClassifier, which is structured similarly to many of the other classifiers we support.
Comment on lines
-33
to
+42
| nvml_device_count = nvml.device_get_count() | ||
| if device_get_count is not None: | ||
| nvml_device_count = device_get_count() | ||
| else: | ||
| try: | ||
| nvml_device_count = pynvml.nvmlDeviceGetCount() | ||
| except Exception: | ||
| nvml_device_count = 0 |
Collaborator
Author
There was a problem hiding this comment.
Would love an opinion here. This code works as is, but I am not sure if the logic is sound enough to cover all cases here.
Was wondering if I should consider copying over relevant functions from https://github.com/dask/distributed/blob/main/distributed/diagnostics/nvml.py ?
Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>
Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>
Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>
Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the beginning of efforts to enable CrossFit functionalities without requiring Dask...
To control this, we use a
DISABLE_DASKtoggle.