wheel builds: react to changes in pip's handling of build constraints #21048
+29
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmccarty
added
improvement
17 tasks
jameslamb
approved these changes
Jan 15, 2026
Member
jameslamb
left a comment
jameslamb
left a comment
There was a problem hiding this comment.
I think this is looking good! Checked the logs for all the wheel builds and saw the things I'd expect.
Similar to rapidsai/ucxx#567 (review):
- suggested an update to a code comment
- suggest we change the PR title to something that'll be more easily understood in the changelog:
"wheel builds: react to changes in pip's handling of build constraints"
If you agree with those, I can commit that comment and then admin-merge this to save us a CI cycle.
mmccarty
changed the title
mmccarty
force-pushed
the
fix/new-build-constraint
branch
from
5f93f3b to
fa5d1dd
Compare
Co-authored-by: James Lamb <jaylamb20@gmail.com>
mmccarty
force-pushed
the
fix/new-build-constraint
branch
from
fa5d1dd to
6ca68c1
Compare
jameslamb
approved these changes
Jan 16, 2026
Member
jameslamb
left a comment
jameslamb
left a comment
There was a problem hiding this comment.
re-approving, I think everything is looking great, thanks!
Member
|
/merge |
rapids-bot
bot
merged commit c6e9a21
into
rapidsai:release/26.02
289 of 290 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to rapidsai/build-planning#242
Modifying
ci/build_wheel.shto avoid passing--build-constraintand--no-build-isolationtogether which results in an error frompip, however we want to keep environment variablePIP_CONSTRAINTset unconditionally.Can be merged after rapidsai/gha-tools#237