Add pure_python option to rapids-download-wheels-from-github
#240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
requested changes
Jan 15, 2026
Member
jameslamb
left a comment
jameslamb
left a comment
There was a problem hiding this comment.
Could you add a PR description explaining why this is necessary?
We already have workflows in RAPIDS successfully downloading pure-python wheels with rapids-download-wheels-from-github, like this:
NX_CUGRAPH_WHEELHOUSE=$(rapids-download-from-github "$(rapids-package-name "wheel_python" "$package_name" --pure --cuda "$RAPIDS_CUDA_VERSION")")(rapidsai/nx-cugraph - ci/test_wheel_nx_cugraph.sh)
For what you're working on (I'm guessing rapidsai/rapids-cmake#966), could you just copy what they're doing instead of introducing another argument here?
Member
Author
|
Yes, I'll do that instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.